RubyGems - activerecord - Versions diffs - 8.0.0.rc2 → 8.0.0 - Mend

activerecord 8.0.0.rc2 → 8.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (10) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +8 -0
data/lib/active_record/attribute_methods.rb +1 -1
data/lib/active_record/connection_adapters/abstract/database_statements.rb +1 -1
data/lib/active_record/gem_version.rb +1 -1
data/lib/active_record/insert_all.rb +1 -1
data/lib/active_record/persistence.rb +1 -1
data/lib/active_record/query_cache.rb +4 -1
data/lib/active_record/relation/query_methods.rb +15 -9
metadata +10 -10

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b6b5ce7951d63889da24f22f9635d27371d6fc733e400d1510cd0ffe27f669e
-  data.tar.gz: 68f851f76e82b3969bc3a7125b3700ce3623ed7cf1717064f26202b4a5c062cd
+  metadata.gz: fdca074c8ca76d0768b2989fb21aaafa5c31f3b80ce1d22275ccfd9d88dd6910
+  data.tar.gz: a282424df2605d4c5239f8eedbeb129fe4190e387e7da03292b6ad13e8b2e0ef
 SHA512:
-  metadata.gz: ef1e91d706ec3c79e71b2e59780a831a63fe82ab45a8e123748c5d073bc120c3d9506d3e8b43b68aa77dc90a5f564b8ef45cb1d5abc19e008127757966bf32dc
-  data.tar.gz: 35e7644e3037334b724042c5f26539c2489c579fede36d461e3661cf04ca79b5c8ca0b3e3c29d8edfc9eab3de15af0b8dcee33a7d88f2f4985c46acfce26a324
+  metadata.gz: f636c65b58ab040b9d820854f97f16df201d08142e50c609bb6acbd1f4817d55c2eeeb3859541c9b26ec47c48b20e01a7ec4e5736a68e6c8ce8d4ecb6342d39a
+  data.tar.gz: 7768bdbf0ff1b8dc3c369fc3168c0c66a56fcf21c00502043f846b1531a8e5962067987e33e43015172a8f346829362598838df197f5fa59f02ed44e9cb6a583

data/CHANGELOG.md CHANGED Viewed

@@ -1,3 +1,11 @@
+## Rails 8.0.0 (November 07, 2024) ##
+*   Fix support for `query_cache: false` in `database.yml`.
+    `query_cache: false` would no longer entirely disable the Active Record query cache.
+    *zzak*
 ## Rails 8.0.0.rc2 (October 30, 2024) ##
 *   NULLS NOT DISTINCT works with UNIQUE CONSTRAINT as well as UNIQUE INDEX.

data/lib/active_record/attribute_methods.rb CHANGED Viewed

@@ -84,7 +84,7 @@ module ActiveRecord
         attribute_method_patterns_cache.clear
       end
-      def alias_attribute_method_definition(code_generator, pattern, new_name, old_name)
+      def alias_attribute_method_definition(code_generator, pattern, new_name, old_name) # :nodoc:
         old_name = old_name.to_s
         if !abstract_class? && !has_attribute?(old_name)

data/lib/active_record/connection_adapters/abstract/database_statements.rb CHANGED Viewed

@@ -674,7 +674,7 @@ module ActiveRecord
               raise AsynchronousQueryInsideTransactionError, "Asynchronous queries are not allowed inside transactions"
             end
-            # We make sure to run query transformers on the orignal thread
+            # We make sure to run query transformers on the original thread
             sql = preprocess_query(sql)
             future_result = async.new(
               pool,

data/lib/active_record/gem_version.rb CHANGED Viewed

@@ -10,7 +10,7 @@ module ActiveRecord
     MAJOR = 8
     MINOR = 0
     TINY  = 0
-    PRE   = "rc2"
+    PRE   = nil
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_record/insert_all.rb CHANGED Viewed

@@ -240,7 +240,7 @@ module ActiveRecord
           values_list = insert_all.map_key_with_value do |key, value|
             next value if Arel::Nodes::SqlLiteral === value
-            types[key].serialize(types[key].cast(value))
+            ActiveModel::Type::SerializeCastValue.serialize(type = types[key], type.cast(value))
           end
           connection.visitor.compile(Arel::Nodes::ValuesList.new(values_list))

data/lib/active_record/persistence.rb CHANGED Viewed

@@ -930,7 +930,7 @@ module ActiveRecord
           )
           returning_columns.zip(returning_values).each do |column, value|
-            _write_attribute(column, value) if !_read_attribute(column)
+            _write_attribute(column, type_for_attribute(column).deserialize(value)) if !_read_attribute(column)
           end if returning_values
         end

data/lib/active_record/query_cache.rb CHANGED Viewed

@@ -35,7 +35,10 @@ module ActiveRecord
     end
     def self.run
-      ActiveRecord::Base.connection_handler.each_connection_pool.reject(&:query_cache_enabled).each(&:enable_query_cache!)
+      ActiveRecord::Base.connection_handler.each_connection_pool.reject(&:query_cache_enabled).each do |pool|
+        next if pool.db_config&.query_cache == false
+        pool.enable_query_cache!
+      end
     end
     def self.complete(pools)

data/lib/active_record/relation/query_methods.rb CHANGED Viewed

@@ -1914,8 +1914,6 @@ module ActiveRecord
         return if with_values.empty?
         with_statements = with_values.map do |with_value|
-          raise ArgumentError, "Unsupported argument type: #{with_value} #{with_value.class}" unless with_value.is_a?(Hash)
           build_with_value_from_hash(with_value)
         end
@@ -1966,10 +1964,10 @@ module ActiveRecord
           table_name = table_name.name if table_name.is_a?(Symbol)
           case columns
           when Symbol, String
-            arel_column_with_table(table_name, columns.to_s)
+            arel_column_with_table(table_name, columns)
           when Array
             columns.map do |column|
-              arel_column_with_table(table_name, column.to_s)
+              arel_column_with_table(table_name, column)
             end
           else
             raise TypeError, "Expected Symbol, String or Array, got: #{columns.class}"
@@ -1979,8 +1977,13 @@ module ActiveRecord
       def arel_column_with_table(table_name, column_name)
         self.references_values |= [Arel.sql(table_name, retryable: true)]
-        predicate_builder.resolve_arel_attribute(table_name, column_name) do
-          lookup_table_klass_from_join_dependencies(table_name)
+        if column_name.is_a?(Symbol) || !column_name.match?(/\W/)
+          predicate_builder.resolve_arel_attribute(table_name, column_name) do
+            lookup_table_klass_from_join_dependencies(table_name)
+          end
+        else
+          Arel.sql("#{model.adapter_class.quote_table_name(table_name)}.#{column_name}")
         end
       end
@@ -1996,6 +1999,8 @@ module ActiveRecord
           arel_column_with_table(table, column)
         elsif block_given?
           yield field
+        elsif Arel.arel_node?(field)
+          field
         else
           Arel.sql(is_symbol ? model.adapter_class.quote_table_name(field) : field)
         end
@@ -2138,7 +2143,7 @@ module ActiveRecord
               arg.expr.relation.name
             end
           end
-        end.compact
+        end.filter_map { |ref| Arel.sql(ref, retryable: true) if ref }
       end
       def extract_table_name_from(string)
@@ -2232,12 +2237,12 @@ module ActiveRecord
           case columns_aliases
           when Hash
             columns_aliases.map do |column, column_alias|
-              arel_column_with_table(table_name, column.to_s)
+              arel_column_with_table(table_name, column)
                 .as(model.adapter_class.quote_column_name(column_alias.to_s))
             end
           when Array
             columns_aliases.map do |column|
-              arel_column_with_table(table_name, column.to_s)
+              arel_column_with_table(table_name, column)
             end
           when String, Symbol
             arel_column(key)
@@ -2248,6 +2253,7 @@ module ActiveRecord
       def process_with_args(args)
         args.flat_map do |arg|
+          raise ArgumentError, "Unsupported argument type: #{arg} #{arg.class}" unless arg.is_a?(Hash)
           arg.map { |k, v| { k => v } }
         end
       end

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord
 version: !ruby/object:Gem::Version
-  version: 8.0.0.rc2
+  version: 8.0.0
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-30 00:00:00.000000000 Z
+date: 2024-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.0.0.rc2
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.0.0.rc2
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.0.0.rc2
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.0.0.rc2
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: timeout
   requirement: !ruby/object:Gem::Requirement
@@ -475,10 +475,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v8.0.0.rc2/activerecord/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v8.0.0.rc2/
+  changelog_uri: https://github.com/rails/rails/blob/v8.0.0/activerecord/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.0.0/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v8.0.0.rc2/activerecord
+  source_code_uri: https://github.com/rails/rails/tree/v8.0.0/activerecord
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options:
@@ -497,7 +497,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Object-relational mapper framework (part of Rails).